For Joomla 3.x don’t use document.id(‘xxx’)

Dimitris

New Member

Posts: 2

10 år 1 måned siden #444 af Dimitris

For Joomla 3.x don’t use document.id(‘xxx’) blev oprettet af Dimitris

Joomla 3.x is supporting IE8 and newer. Using this legacy mootools code is useless. For example the following code:

<script type="text/javascript">
    js = jQuery.noConflict();
    js(document).ready(function() {
        
    });
    Joomla.submitbutton = function(task)
    {
        if (task == 'basic.cancel') {
            Joomla.submitform(task, document.getElementById('basic-form'));
        }
        else {
            
            if (task != 'basic.cancel' && document.formvalidator.isValid(document.id('basic-form'))) {
                
                Joomla.submitform(task, document.getElementById('basic-form'));
            }
            else {
                alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED')); ?>');
            }
        }
    }
</script>

Can be:

if (task != 'basic.cancel' && document.formvalidator.isValid(document.getElementById('basic-form'))) {

Without any compromise.

Recently I propose removing these legacy mootools methods in Joomla PR

Thanks Dimitris

Venligst Log på eller Opret en konto for at deltage i samtalen

Andres Maeso

Platinum Member

Posts: 338

10 år 1 måned siden #446 af Andres Maeso

Besvaret af Andres Maeso på emne For Joomla 3.x don’t use document.id(‘xxx’)

Hey there!

Thanks for your feedback, actually it's a good idea, but as you probably know we stick to Joomla Standards, so we can't remove them until they're removed from Joomla Core. But please, do not hesitate to come back to us when they accept the PR

Regards,

Andrés.

Andrés Maeso
Customer relations manager at Joomla Component Creator.

Denne e-mail adresse bliver beskyttet mod spambots. Du skal have JavaScript aktiveret for at vise den.

Venligst Log på eller Opret en konto for at deltage i samtalen

Dimitris

New Member

Posts: 2

9 år 10 måneder siden #582 af Dimitris

Besvaret af Dimitris på emne For Joomla 3.x don’t use document.id(‘xxx’)

FYI Joomla 3.4 is scheduled for mid February and has those changes. Also There is a JTHML::(behavior.formvalidator); instead of the JTHML::(behavior.formvalidation); which uses only jQuery.

Venligst Log på eller Opret en konto for at deltage i samtalen

Andres Maeso

Platinum Member

Posts: 338

9 år 10 måneder siden #583 af Andres Maeso

Besvaret af Andres Maeso på emne For Joomla 3.x don’t use document.id(‘xxx’)

Thank you Dimitris, duly noted. I'll pass it to our developers.

Andrés Maeso
Customer relations manager at Joomla Component Creator.

Denne e-mail adresse bliver beskyttet mod spambots. Du skal have JavaScript aktiveret for at vise den.

Venligst Log på eller Opret en konto for at deltage i samtalen

Tid til at oprette siden: 0.052 sekunder

Leveret af Kunena Forum