For Joomla 3.x don’t use document.id(‘xxx’)

Dimitris

Fresh Boarder

Posts: 2

10 Jahre 1 Monat her #444 von Dimitris

For Joomla 3.x don’t use document.id(‘xxx’) wurde erstellt von Dimitris

Joomla 3.x is supporting IE8 and newer. Using this legacy mootools code is useless. For example the following code:

<script type="text/javascript">
    js = jQuery.noConflict();
    js(document).ready(function() {
        
    });
    Joomla.submitbutton = function(task)
    {
        if (task == 'basic.cancel') {
            Joomla.submitform(task, document.getElementById('basic-form'));
        }
        else {
            
            if (task != 'basic.cancel' && document.formvalidator.isValid(document.id('basic-form'))) {
                
                Joomla.submitform(task, document.getElementById('basic-form'));
            }
            else {
                alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED')); ?>');
            }
        }
    }
</script>

Can be:

if (task != 'basic.cancel' && document.formvalidator.isValid(document.getElementById('basic-form'))) {

Without any compromise.

Recently I propose removing these legacy mootools methods in Joomla PR

Thanks Dimitris

Bitte Anmelden oder Registrieren um der Konversation beizutreten.

Andres Maeso

Platinum Boarder

Posts: 338

10 Jahre 1 Monat her #446 von Andres Maeso

Andres Maeso antwortete auf For Joomla 3.x don’t use document.id(‘xxx’)

Hey there!

Thanks for your feedback, actually it's a good idea, but as you probably know we stick to Joomla Standards, so we can't remove them until they're removed from Joomla Core. But please, do not hesitate to come back to us when they accept the PR

Regards,

Andrés.

Andrés Maeso
Customer relations manager at Joomla Component Creator.

Diese E-Mail-Adresse ist vor Spambots geschützt! Zur Anzeige muss JavaScript eingeschaltet sein!

Bitte Anmelden oder Registrieren um der Konversation beizutreten.

Dimitris

Fresh Boarder

Posts: 2

9 Jahre 10 Monate her #582 von Dimitris

Dimitris antwortete auf For Joomla 3.x don’t use document.id(‘xxx’)

FYI Joomla 3.4 is scheduled for mid February and has those changes. Also There is a JTHML::(behavior.formvalidator); instead of the JTHML::(behavior.formvalidation); which uses only jQuery.

Bitte Anmelden oder Registrieren um der Konversation beizutreten.

Andres Maeso

Platinum Boarder

Posts: 338

9 Jahre 10 Monate her #583 von Andres Maeso

Andres Maeso antwortete auf For Joomla 3.x don’t use document.id(‘xxx’)

Thank you Dimitris, duly noted. I'll pass it to our developers.

Andrés Maeso
Customer relations manager at Joomla Component Creator.

Diese E-Mail-Adresse ist vor Spambots geschützt! Zur Anzeige muss JavaScript eingeschaltet sein!

Bitte Anmelden oder Registrieren um der Konversation beizutreten.

Ladezeit der Seite: 0.065 Sekunden