For Joomla 3.x don’t use document.id(‘xxx’)

Dimitris

New Member

Posts: 2

10 Anni 1 Mese fa #444 da Dimitris

For Joomla 3.x don’t use document.id(‘xxx’) è stato creato da Dimitris

Joomla 3.x is supporting IE8 and newer. Using this legacy mootools code is useless. For example the following code:

<script type="text/javascript">
    js = jQuery.noConflict();
    js(document).ready(function() {
        
    });
    Joomla.submitbutton = function(task)
    {
        if (task == 'basic.cancel') {
            Joomla.submitform(task, document.getElementById('basic-form'));
        }
        else {
            
            if (task != 'basic.cancel' && document.formvalidator.isValid(document.id('basic-form'))) {
                
                Joomla.submitform(task, document.getElementById('basic-form'));
            }
            else {
                alert('<?php echo $this->escape(JText::_('JGLOBAL_VALIDATION_FORM_FAILED')); ?>');
            }
        }
    }
</script>

Can be:

if (task != 'basic.cancel' && document.formvalidator.isValid(document.getElementById('basic-form'))) {

Without any compromise.

Recently I propose removing these legacy mootools methods in Joomla PR

Thanks Dimitris

Si prega Accedi o Crea un account a partecipare alla conversazione.

Andres Maeso

Platinum Member

Posts: 338

10 Anni 1 Mese fa #446 da Andres Maeso

Risposta da Andres Maeso al topic For Joomla 3.x don’t use document.id(‘xxx’)

Hey there!

Thanks for your feedback, actually it's a good idea, but as you probably know we stick to Joomla Standards, so we can't remove them until they're removed from Joomla Core. But please, do not hesitate to come back to us when they accept the PR

Regards,

Andrés.

Andrés Maeso
Customer relations manager at Joomla Component Creator.

Questo indirizzo email è protetto dagli spambots. È necessario abilitare JavaScript per vederlo.

Si prega Accedi o Crea un account a partecipare alla conversazione.

Dimitris

New Member

Posts: 2

9 Anni 10 Mesi fa #582 da Dimitris

Risposta da Dimitris al topic For Joomla 3.x don’t use document.id(‘xxx’)

FYI Joomla 3.4 is scheduled for mid February and has those changes. Also There is a JTHML::(behavior.formvalidator); instead of the JTHML::(behavior.formvalidation); which uses only jQuery.

Si prega Accedi o Crea un account a partecipare alla conversazione.

Andres Maeso

Platinum Member

Posts: 338

9 Anni 10 Mesi fa #583 da Andres Maeso

Risposta da Andres Maeso al topic For Joomla 3.x don’t use document.id(‘xxx’)

Thank you Dimitris, duly noted. I'll pass it to our developers.

Andrés Maeso
Customer relations manager at Joomla Component Creator.

Questo indirizzo email è protetto dagli spambots. È necessario abilitare JavaScript per vederlo.

Si prega Accedi o Crea un account a partecipare alla conversazione.

Tempo creazione pagina: 0.055 secondi